Skip to content

[TASK] Add native type declarations for Import #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2025
Merged

[TASK] Add native type declarations for Import #1172

merged 1 commit into from
Mar 16, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #811

@oliverklee oliverklee requested a review from JakeQZ March 16, 2025 10:12
@oliverklee oliverklee self-assigned this Mar 16, 2025
@coveralls
Copy link

coveralls commented Mar 16, 2025 •
edited
Loading

Coverage Status

coverage: 55.727%. remained the same
when pulling eb96b36 on task/types/import
into e0e0dd3 on main.

JakeQZ
JakeQZ reviewed Mar 16, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code, it seems an empty string is used to indicate 'no media query', but perhaps null is clearer. The constructor could perhaps have that as a default value, but maybe as a separate PR.

@oliverklee
Copy link
Collaborator Author

Looking at the code, it seems an empty string is used to indicate 'no media query'

There is some calling code that explicitly passes null. We could change the code use non-empty-string|null for $mediaQuery. What do think?

JakeQZ
JakeQZ approved these changes Mar 16, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some calling code that explicitly passes null. We could change the code use non-empty-string|null for $mediaQuery. What do think?

I've added #1177 to capture this.

@JakeQZ JakeQZ merged commit 4889353 into main Mar 16, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/types/import branch March 16, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ